✨ Sync 2026-10-11 20:48:25

luci-app-homeproxy/tests/ucode/test_firewall_template.sh

@@ -1,15 +1,5 @@
 #!/bin/sh
 # SPDX-License-Identifier: GPL-2.0-only
-#
-# Render firewall_post.ut and verify the homeproxy fw4 objects survive as real
-# nft statements.
-#
-# The template opens with `{%-`, which trims the whitespace in front of it: any
-# text placed above that tag loses its trailing newline and is glued onto the
-# first generated statement, turning it into a comment. That silently dropped
-# every homeproxy chain/set from the fw4 ruleset once, so keep this check.
-#
-# Usage: sh tests/ucode/test_firewall_template.sh <repo-root>
 
 ROOT="${1:-.}"
 ROOT="$(cd "$ROOT" && pwd)"
@@ -23,8 +13,6 @@ if ! utpl -S "$ROOT/root/etc/homeproxy/scripts/firewall_post.ut" > "$OUT" 2>"/tm
 	exit 1
 fi
 
-# Declared unconditionally by the template, so they must always be present as
-# standalone statements.
 for name in homeproxy_local_addr_v4 homeproxy_wan_proxy_addr_v4; do
 	if ! grep -q "^set $name {" "$OUT"; then
 		echo "FAIL: 'set $name {' is missing from the rendered firewall template"
@@ -33,8 +21,6 @@ for name in homeproxy_local_addr_v4 homeproxy_wan_proxy_addr_v4; do
 	fi
 done
 
-# A statement glued onto the preceding comment looks like
-# "# <comment text>.set homeproxy_x {" -- exactly the failure mode above.
 if grep -nE "^#[^!].*homeproxy_[a-z0-9_]+ \{" "$OUT" > "/dev/null"; then
 	echo "FAIL: an nft statement is glued onto a comment line"
 	grep -nE "^#[^!].*homeproxy_[a-z0-9_]+ \{" "$OUT" | head -2