✨ Sync 2026-10-11 20:48:25

luci-app-homeproxy/tests/ucode/test_homeproxy_utils.uc

@@ -3,10 +3,6 @@
  * SPDX-License-Identifier: GPL-2.0-only
  *
  * Copyright (C) 2025 ImmortalWrt.org
- *
- * Regression tests for homeproxy.uc helpers, focused on executeCommand():
- * return shape, stderr/exit-code capture, binary detection and (most
- * importantly) that the temporary descriptors are closed on every run.
  */
 
 'use strict';
@@ -32,7 +28,6 @@ function fd_count() {
 	return n;
 }
 
-/* successful command */
 const ok = executeCommand('echo', 'hello');
 expect('ok.exitcode', ok.exitcode, 0);
 expect('ok.stdout', ok.stdout, 'hello\n');
@@ -40,29 +35,22 @@ expect('ok.stderr', ok.stderr, '');
 expect('ok.binary', ok.binary, false);
 expect('ok.command', ok.command, 'echo hello');
 
-/* failing command keeps stderr and the exit code */
 const bad = executeCommand('sh', '-c', shellQuote('echo oops >&2; exit 3'));
 expect('bad.exitcode', bad.exitcode, 3);
 expect('bad.stderr', bad.stderr, 'oops\n');
 expect('bad.stdout', bad.stdout, '');
 
-/* nondescript exit code */
 expect('false.exitcode', executeCommand('false').exitcode, 1);
 
-/* binary output is detected and withheld */
 const bin = executeCommand('sh', '-c', shellQuote('printf "\\001\\002\\003"'));
 expect('bin.binary', bin.binary, true);
 expect('bin.stdout', bin.stdout, null);
 
-/* output larger than the old one-shot 512 KiB read must not be truncated
-   (subscription lists above that size used to arrive cut in half) */
 const big_want = 700 * 1024;
 const big = executeCommand('sh', '-c', shellQuote('yes a | head -c ' + big_want));
 expect('big.exitcode', big.exitcode, 0);
 expect('big.length', length(big.stdout), big_want);
 
-/* isValidCIDR(): the prefix needs the same strict validation as the address,
-   otherwise a poisoned resource file reaches the nftables template */
 expect('cidr.ok', isValidCIDR('1.2.3.4/24', 4), true);
 expect('cidr.bare', isValidCIDR('1.2.3.4', 4), true);
 expect('cidr.bad-prefix', isValidCIDR('1.2.3.4/abc', 4), false);
@@ -73,7 +61,6 @@ expect('cidr.injection', isValidCIDR('1.2.3.4/0 } flush ruleset; table inet x {'
 expect('cidr.v6-ok', isValidCIDR('2001:db8::/32', 6), true);
 expect('cidr.v6-injection', isValidCIDR('2001:db8::/32 } flush ruleset;', 6), false);
 
-/* isValidPEM(): certificate vs private key, boundaries and body */
 const pem_cert = '-----BEGIN CERTIFICATE-----\nAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\n-----END CERTIFICATE-----';
 const pem_key = '-----BEGIN RSA PRIVATE KEY-----\nAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\n-----END RSA PRIVATE KEY-----';
 expect('pem.cert', isValidPEM(pem_cert, false), true);
@@ -83,7 +70,6 @@ expect('pem.key-as-cert', isValidPEM(pem_key, false), false);
 expect('pem.garbage', isValidPEM('not a pem at all', false), false);
 expect('pem.empty', isValidPEM('', false), false);
 
-/* descriptors must not leak across calls */
 const before = fd_count();
 for (let i = 0; i < 200; i++)
 	executeCommand('true');