🌴 Sync 2026-09-09 14:20:42

luci-app-mptcp/htdocs/luci-static/resources/view/mptcp/mptcp.js

@@ -295,10 +295,11 @@ return L.view.extend({
 	o.default = "off";
 	// Same rmempty/default collision as mptcp_pm_type above: without this,
 	// every interface currently set to "off" has network.<iface>.multipath
-	// silently deleted on each Save & Apply of this page. Currently harmless
-	// (the init script's own fallback for an absent value is also "off"),
-	// but keep the persisted value explicit so a future fallback change
-	// can't quietly flip behavior for these interfaces too.
+	// silently deleted on each Save & Apply of this page. Not harmless: the
+	// init script falls back to its own copy of the mode in
+	// openmptcprouter.<iface>.multipath before it falls back to "off", so a
+	// deleted setting brings back whatever mode the interface had before
+	// (discussion #4368).
 	o.rmempty = false;
 
 	o = s.option(form.Value, "multipath_weight", _("Weight"), _("Only used by *weight schedulers/path managers. Ignored if no weight scheduler is selected.") + '<br />' + _("A weight >100 make it more attractive, a weight <100 make it less attractive. Max 256"));

luci-app-mptcp/root/usr/libexec/rpcd/luci.mptcp

@@ -847,7 +847,13 @@ local methods = {
 			local iface     = args.iface or ""
 			local interface = get_device(iface)
 			local server    = uci:get("shadowsocks-libev", "sss0", "server") or ""
-			if server == "" then return { output = "" } end
+			-- Placeholders the shadowsocks config ships until a VPS is set
+			-- (127.0.0.1 now, 192.168.1.3 in older releases): tracing to them
+			-- would report a path that has nothing to do with the proxy.
+			if server == "" or server == "127.0.0.1" or server == "::1"
+			   or server == "192.168.1.3" then
+				return { output = "" }
+			end
 			local cmd
 			if interface == "" then
 				cmd = "tracebox -s /usr/share/tracebox/omr-mptcp-trace.lua " .. server