mirror of
https://github.com/kiddin9/op-packages.git
synced 2026-10-26 18:52:51 +08:00
fix: sanitize shell/subprocess call in docker_rpc.uc
The run_ttyd function constructs shell commands using template literals that directly interpolate user-supplied parameters (id, cmd, port, uid) without validation
This commit is contained in:
1 parent
4b4d482791
commit
3b2bab15d4
1 file changed
+9
@@ -316,6 +316,15 @@ function run_ttyd(request) {
|
||||
return { error: 'Container ID is required' };
|
||||
}
|
||||
|
||||
// Strictly validate all user-supplied values before they are interpolated
|
||||
// into a shell command string to prevent command injection.
|
||||
if (!match(id, /^[a-zA-Z0-9][a-zA-Z0-9_.-]*$/) ||
|
||||
!match(`${port}`, /^[0-9]{1,5}$/) || int(port) < 1 || int(port) > 65535 ||
|
||||
(uid && !match(`${uid}`, /^[a-zA-Z0-9_-]+$/)) ||
|
||||
!match(cmd, /^[a-zA-Z0-9_\/.\- ]+$/)) {
|
||||
return { error: 'Invalid parameter supplied' };
|
||||
}
|
||||
|
||||
let ttyd_cmd = `ttyd -q -d 2 --once --writable -p ${port} docker`;
|
||||
const sock_addr = ds.get_socket_dest();
|
||||
|
||||
|
||||
Reference in new issue
Block a user